[Nagios-devel] Patchs proposal

nap naparuba at gmail.com
Thu May 14 14:34:38 UTC 2009


On Thu, May 14, 2009 at 4:06 PM, Andreas Ericsson <ae at op5.se> wrote:
> nap wrote:
>> Hi,
>>
>> If it's the patchs's day, I repost some of my patch proposal:
>>
>>
>> Circular-parent2.patch : change the host circular check algorithm (no
>> cycle in parents) by a Deep First Search based one. It really speed up
>> the circular check and provide the same output as the old one, so can
>> be apply without problem.
>>
>
> I really like this one, although with the current implementation, it
> can't be applied without breaking the ABI for eventbroker modules,
> which we're definitely loathe to do.
>
> However, hosts have plenty of un-used bits in many of the integral
> variables used as boolean flags. If you could rewrite the patch so
> that one of those fields is used instead, I'd take this patch and
> put it through the wringer without hesitation.
>
>> Changepriority_service_on_hostgroup.patch : change the order of
>> services in skiplist so services apply on host come before service
>> apply on hostgroups. So When a service is apply in a host, it will be
>> take even if a other service have been apply on a hostgroup where the
>> host is. It can be use to override definition. It changes the
>> behaviour of configuration but still raise warnings in the
>> configuration check.
>>
>
> This patch has the same problem as the afore-mentioned one, in that
> it changes the size of the service objects and thus breaks the
> ABI. The same holds true here though; There are plenty of un-used
> bits in the integral boolean flags that can be utilized instead.
>
> For both the two patches mentioned above, one extra pass over all
> objects has to be done to clear the bitflags once they're set.
> I'd much prefer if you were to create small helper functions for
> these routines, like so:
>
> void dfs_set_host_unchecked(struct host_object *hst)
> {
>    hst->notify_on_errors &= 1;
> }
>
> int dfs_host_is_checked(struct host_object *hst)
> {
>    return hst->notify_on_errors & (1 << 10);
> }
>
> void dfs_set_host_checked(struct host_object *hst)
> {
>    hst->notify_on_errors |= (1 << 10);
> }
>
>
> I'm sure you get the idea. Care to amend the patches in such a way?
Ok, I'm on it :)

>
>> Ndo14b7_ssl_patch_v2 : user can use SSL connexion between ndomod and
>> ndo2db. The option use_ssl is add in ndomod.cfg and ndo2db.cfg. If
>> omitted, the SSL is used by default. The patch is not fully completed
>> because the autoconf part is not finish (I took the code from NRPE). I
>> never take thetime to, so if someone want to finish this part...
>>
>
> I won't comment on this since I know very little about NDOUtils.
>
>>
>> Gabès Jean
>>
>
> Is Gabès your first name or your surname? I need to know to get the
> attribution correct for when I apply the patches.
last name : Gabès
first name : Jean

>
> Thanks.
>

Gabès Jean

> --
> Andreas Ericsson                   andreas.ericsson at op5.se
> OP5 AB                             www.op5.se
> Tel: +46 8-230225                  Fax: +46 8-230231
>
> Register now for Nordic Meet on Nagios, June 3-4 in Stockholm
>  http://nordicmeetonnagios.op5.org/
>
> Considering the successes of the wars on alcohol, poverty, drugs and
> terror, I think we should give some serious thought to declaring war
> on peace.
>
> ------------------------------------------------------------------------------
> The NEW KODAK i700 Series Scanners deliver under ANY circumstances! Your
> production scanning environment may not be a perfect world - but thanks to
> Kodak, there's a perfect scanner to get the job done! With the NEW KODAK i700
> Series Scanner you'll get full speed at 300 dpi even with all image
> processing features enabled. http://p.sf.net/sfu/kodak-com
> _______________________________________________
> Nagios-devel mailing list
> Nagios-devel at lists.sourceforge.net
> https://lists.sourceforge.net/lists/listinfo/nagios-devel
>




More information about the Nagios-devel mailing list